Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug where the Join Room screen was sometimes shown instead of the Room. #3323

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Fix a bug where the Join Room screen was sometimes shown instead of the Room. #3323

merged 1 commit into from
Sep 24, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Sep 24, 2024 •
edited
Loading

Updates the SDK which fixes #3270 by including matrix-org/matrix-rust-sdk#4021

@pixlwave pixlwave added the pr-bugfix for bug fix label Sep 24, 2024
@pixlwave pixlwave requested a review from a team as a code owner September 24, 2024 08:54
@pixlwave pixlwave requested review from Velin92 and removed request for a team September 24, 2024 08:54
@github-actions GitHub Actions
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 347df14

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov Codecov
Copy link

codecov bot commented Sep 24, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
824 2 822 0
View the top 1 failed tests by shortest run time 
UserSessionFlowCoordinatorTests testEventRoutes()
Stack Traces | 0.35s run time 
XCTAssertEqual failed: ("3") is not equal to ("4") (.../UnitTests/Sources/UserSessionFlowCoordinatorTests.swift:239)
View the full list of 1 ❄️ flaky tests 
PreviewTests test_roomMemberDetailsScreen()

Flake rate in main: 13.51% (Passed 32 times, Failed 5 times)

Stack Traces | 28.8s run time 
failed - Snapshot "Other User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-pseudo.Other-User.png"
@+
"file:.../tmp/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-pseudo.Other-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.913147 is less than required 1.0
The lowest perceptual color precision 0.29250002 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:66)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@pixlwave
Copy link
Member Author

Hmmm the failure was a timeout. The preview tests seemed nice and stable before I merged the Xcode 16 stuff 🤦‍♂️

@pixlwave pixlwave merged commit d736812 into develop Sep 24, 2024
8 of 9 checks passed
@pixlwave pixlwave deleted the doug/sdk branch September 24, 2024 10:33
@pixlwave pixlwave mentioned this pull request Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanceriu stefanceriu stefanceriu approved these changes

@Velin92 Velin92 Awaiting requested review from Velin92 Velin92 is a code owner automatically assigned from element-hq/element-x-ios-reviewers

Assignees
No one assigned
Labels
pr-bugfix for bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tapping alternating rooms can lead to ElX displaying a "Join Room" screen
2 participants
@pixlwave @stefanceriu